<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 5, 2013 at 11:58 AM, Garnet Vaz <span dir="ltr"><<a href="mailto:garnet.vaz@gmail.com" target="_blank">garnet.vaz@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":23b">The latest patch causes a symbol re-definition error in:<br>

petsc-dev / src / ksp / pc / impls / gamg / gamg.h<br>
and<br>
petsc-dev / src / ksp / pc / impls / gamg / gamg.c<br>
<br>
for the logging events. Do you still<br>
need the definitions in gamg.c?</div></blockquote></div><br>I needed to make PETSC_INTERN function as a declaration.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><a href="https://bitbucket.org/petsc/petsc-dev/commits/6a9a17f5e4246d8acc34f070600a2e416281c345">https://bitbucket.org/petsc/petsc-dev/commits/6a9a17f5e4246d8acc34f070600a2e416281c345</a><br>
</div><div class="gmail_extra"><br></div><div class="gmail_extra" style>Can we want to make all logging events internal? That would spoil the ability to use PetscLogEventSetActiveAll(MAT_SetValues,PETSC_TRUE), but we have PetscLogEventGetId() which should be better for users anyway.</div>
</div>