<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 7, 2013 at 5:18 PM, Matthew Knepley <span dir="ltr"><<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">5)<br>
#define KSPGMRES "gmres"<br>
<br>
?<br></blockquote><div><br></div></div><div>We had this argument. The typedef behaves in a weird was with 'const'.</div></blockquote><div><br></div><div style>Huh? We already have typedef const char *KSPType. It's easy to replace these with constant data (extern KSPType KSPGMRES), but that's harder to read and we still have to define it for Fortran as well.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
6)<br>
#if defined(PETSC_HAVE_SOMEINCLUDE)<br>
#include <someinclude.h><br>
<br>
I was thinking we could auto generate empty someinclude.h for these (putting in $PETSC_ARCH/include) Cheesy but ?<br></blockquote><div><br></div></div><div>Hmm, that seems fragile. I would rather generate the header lists.</div>
</blockquote></div><br>Where is the programmer going to state which headers they need in a specific source file?</div></div>