<div dir="ltr">On Tue, Jan 22, 2013 at 3:51 PM, Karl Rupp <span dir="ltr"><<a href="mailto:rupp@mcs.anl.gov" target="_blank">rupp@mcs.anl.gov</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
MPI 3.0 *removes* a set of functions from MPI 1.x, of which the<br>
following are in use in PETSc:<br>
<br>
* MPI_Type_struct, used in<br></div>
src/ts/characteristic/impls/__<u></u>da/slda.c<br>
src/dm/impls/mesh/meshpcice.c<br>
<br>
* MPI_Errhandler_create/MPI___<u></u>Errhandler_set, used in<div class="im"><br>
src/sys/objects/pinit.c<br>
src/sys/objects/init.c<br>
<br>
In both cases function were renamed in MPI-2.0:<br>
MPI_Type_struct -> MPI_Type_create_struct<br>
MPI_Errhandler_create -> MPI_Comm_create_errhandler<br>
MPI_Errhandler_set -> MPI_Comm_set_errhandler<br>
<br></div><div class="im">
It should be sufficient to update<br></div>
BuildSystem/config/packages/__<u></u>MPI.py and add the respective checks<div class="im"><br>
in configureMPI2(). Any objections on the following defines:<br>
HAVE_MPI_TYPE_CREATE_STRUCT<br></div>
HAVE_MPI_COMM_CREATE___<u></u>ERRHANDLER<div class="im"><br>
HAVE_MPI_COMM_SET_ERRHANDLER<br>
in the case of success?<br>
<br>
<br>
Yes, this is the right way.<br>
<br></div>
Matt<br>
</blockquote>
<br>
Since there was a lack of consensus on alternatives, I applied Matt's Right Way here:<br>
<a href="https://bitbucket.org/petsc/petsc-dev/commits/fabf60c7d012db5a109255579665b5c2" target="_blank">https://bitbucket.org/petsc/<u></u>petsc-dev/commits/<u></u>fabf60c7d012db5a109255579665b5<u></u>c2</a><br>
<a href="https://bitbucket.org/petsc/buildsystem/commits/355293e9e4e0588644168f629930b566" target="_blank">https://bitbucket.org/petsc/<u></u>buildsystem/commits/<u></u>355293e9e4e0588644168f629930b5<u></u>66</a><br>
<br>
This is mostly done to ensure that we don't forget about the initial goal of fixing the issue. Cleaner/more unified solutions to the problem are still welcome...<br></blockquote><div><br></div><div style>This is almost there. I will have BuildSystem write the define directly like Barry suggested.</div>
<div style><br></div><div style> Thanks,</div><div style><br></div><div style> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Best regards,<br>
Karli<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>
-- Norbert Wiener
</div></div>