I like it.<div><br></div><div> Matt<br><br><div class="gmail_quote">On Fri, Jul 27, 2012 at 2:35 PM, Jed Brown <span dir="ltr"><<a href="mailto:jedbrown@mcs.anl.gov" target="_blank">jedbrown@mcs.anl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><font face="arial, helvetica, sans-serif">I'm sick of truncated PETSC_ARCH in log_summary. Does anyone object to my pushing the following to petsc-3.3? Should we just make all the fields huge so we're guaranteed to get everything? Since pname can be as long as PETSC_MAX_PATH_LEN, this is not a line we can reasonably limit/align.</font></div>
<div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace">--- a/src/sys/plog/plog.c</font></div><div><font face="courier new, monospace">+++ b/src/sys/plog/plog.c</font></div><div>
<font face="courier new, monospace">@@ -1269,7 +1269,7 @@</font></div><div><font face="courier new, monospace"> PetscStageInfo *stageInfo = PETSC_NULL;</font></div><div><font face="courier new, monospace"> PetscEventPerfInfo *eventInfo = PETSC_NULL;</font></div>
<div><font face="courier new, monospace"> PetscClassPerfInfo *classInfo;</font></div><div><font face="courier new, monospace">- char arch[10], hostname[64], username[16], pname[PETSC_MAX_PATH_LEN], date[64];</font></div>
<div><font face="courier new, monospace">+ char arch[64], hostname[128], username[16], pname[PETSC_MAX_PATH_LEN], date[64];</font></div><div><font face="courier new, monospace"> const char *name;</font></div>
<div><font face="courier new, monospace"> PetscLogDouble locTotalTime, TotalTime, TotalFlops;</font></div><div><font face="courier new, monospace"> PetscLogDouble numMessages, messageLength, avgMessLen, numReductions;</font></div>
<div><font face="courier new, monospace">@@ -1311,12 +1311,12 @@</font></div><div><font face="courier new, monospace"> ierr = PetscFPrintf(comm, fd, "*** WIDEN YOUR WINDOW TO 120 CHARACTERS. Use 'enscript -r -fCourier9' to print this document ***\n");CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace"> ierr = PetscFPrintf(comm, fd, "************************************************************************************************************************\n");CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace"> ierr = PetscFPrintf(comm, fd, "\n---------------------------------------------- PETSc Performance Summary: ----------------------------------------------\n\n");CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace">- ierr = PetscGetArchType(arch, 10);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace">- ierr = PetscGetHostName(hostname, 64);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace">- ierr = PetscGetUserName(username, 16);CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace">+ ierr = PetscGetArchType(arch,sizeof arch);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace">+ ierr = PetscGetHostName(hostname,sizeof hostname);CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace">+ ierr = PetscGetUserName(username,sizeof username);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace"> ierr = PetscGetProgramName(pname, PETSC_MAX_PATH_LEN);CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace">- ierr = PetscGetDate(date, 64);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace">- ierr = PetscGetVersion(version,256);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace">+ ierr = PetscGetDate(date,sizeof date);CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace">+ ierr = PetscGetVersion(version,sizeof version);CHKERRQ(ierr);</font></div><div><font face="courier new, monospace"> if (size == 1) {</font></div><div><font face="courier new, monospace"> ierr = PetscFPrintf(comm,fd,"%s on a %s named %s with %d processor, by %s %s\n", pname, arch, hostname, size, username, date);CHKERRQ(ierr);</font></div>
<div><font face="courier new, monospace"> } else {</font></div><div><br></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>
-- Norbert Wiener<br>
</div>