<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
The TransplantPlaceArray, TransplantResetArray was very experimental
and should have not have been committed. I removed it.<br>
<br>
<br>
<br>
<br>
<blockquote
cite="mid:CAM9tzSmL5Dn0yUgLO4M--iYtZVjd_QNWwFRE_Pdb7cR6ge0pGw@mail.gmail.com"
type="cite">This is minutia now, but this statement is nonsense
(it triggers -Waddress and is meaningless).
<div><br>
</div>
<div> 38.66 + if (&y_array) y_array = PETSC_NULL;<br>
<br>
<div class="gmail_quote">On Thu, Jun 28, 2012 at 2:53 PM, Jed
Brown <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jedbrown@mcs.anl.gov" target="_blank">jedbrown@mcs.anl.gov</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote">
<div class="im">On Thu, Jun 28, 2012 at 2:41 PM, Paul
Mullowney <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:paulm@txcorp.com" target="_blank">paulm@txcorp.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I moved all
CUSPARSE functions into seqcusparse/<a
moz-do-not-send="true"
href="http://aijcusparse.cu" target="_blank">aijcusparse.cu</a>
(and a similar mpi version). I was asked to do this
some months ago. I did my best. I think it is
significantly improved from before.<br>
<br>
I was also asked by multiple people to attempt to
get Complex GPU capabilities working. I succeeded by
making changes to petscmath.h. As Jed pointed out,
some of the changes may have not been C99 compliant.
<br>
</div>
</blockquote>
<div><br>
</div>
</div>
<div>It needs to work with C89, not just C99. Global
changes to handle complex should also be done in
separate patches.</div>
<div><br>
</div>
<div>I hate the idea that CUSP leaks out into user code so
I would recommend casting internally rather than
changing it globally. That should also enable use of
complex without requiring the user to adopt a C++
compiler for their own code (C99 _Complex is
binary-compatible with std::complex and cusp::complex).</div>
<div class="im">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
There is one commented out function in <a
moz-do-not-send="true"
href="http://aijcusparse.cu" target="_blank">aijcusparse.cu</a>.
That can easily be fixed. <br>
<br>
Many of the other changes (especially to .cu) files
were made to protect against builds breaking because
many of the CUSP preconditioners do not support
complex arithmetic.<br>
</div>
</blockquote>
<div><br>
</div>
</div>
<div>Those should absolutely be in separate patches.
Lumping it all into one makes it impossible to review or
test.</div>
<div class="im">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
I have asked for input from multiple people on
several occasions and not gotten responses. <br>
<br>
What am I to do if I ask for input/feedback and
don't get it?????</div>
</blockquote>
<div><br>
</div>
</div>
<div>Next time, please provide the patch series. You could
use "hg email" or post your branch to bitbucket or
elsewhere so that we can comment.</div>
<div><br>
</div>
<div>Also, please follow the coding guidelines. There is a
developer's manual and frequent discussion on petsc-dev
about conventions. (If you notice something that is
adopted, but not in the developer's manual, please point
it out on the mailing list or make a patch.)</div>
<div class="im">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span><font
color="#888888"><br>
<br>
-Paul</font></span>
<div><br>
<br>
<br>
<blockquote type="cite">
<div class="gmail_quote">
<div><br>
</div>
<div>There are essentially no comments on this
massive push. I was just reading it, getting
mad. Jed mailed first.</div>
<div>Pushes need enough comments that I can
see exactly what functionality is being
added and how it works.</div>
<div>You will not be the maintainer of this
functionality, we will. If we can't do it,
it will be thrown out, and all your</div>
<div>time will be wasted.</div>
<div><br>
</div>
<div> Matt</div>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div class="gmail_quote">
<div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div>
<div><br>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"> This is
non-portable:<br>
<br>
<a moz-do-not-send="true"
href="http://petsc.cs.iit.edu/petsc/petsc-dev/rev/66ca8db0d5f8"
target="_blank">http://petsc.cs.iit.edu/petsc/petsc-dev/rev/66ca8db0d5f8</a><br>
<br>
<br>
Can we please institute some
sort of policy on patch
quality/reviewability? This one
patch is going to take a
significant amount of fix-up
(not made easier by the several
merges since) and/or generate
several build failures and user
inconvenience (petsc-maints). No
doubt the functionality is
important, but we just don't
have time to fix these things
line-by-line after they are
pushed.<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
</div>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
What most experimenters take for granted before
they begin their experiments is infinitely more
interesting than any results to which their
experiments lead.<br>
-- Norbert Wiener<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
</div>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>