<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 17, 2012, at 4:41 PM, Jed Brown wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Sat, Mar 17, 2012 at 15:32, Mark F. Adams <span dir="ltr"><<a href="mailto:mark.adams@columbia.edu">mark.adams@columbia.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>done, but it won't show up until I check in my current repo, which could be a week.</div></blockquote><div><br></div><div>Thanks, I suspect this will have the side-effect of making it easier for the rest of us to navigate your code. I rely on tab-completion of gtags for a lot of things, but even just having the functions names sort nicely helps.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="im"><br><blockquote type="cite">
<div><br></div><div>I don't understand why you have this gamg_setup_events. These event names are anything but intuitive in the sense that they don't stand alone and is denormalized (which makes it non-grepable). I also don't think it makes sense for GAMG to have its own classid since it's not a new PetscObject. I suggest registering with</div>
<div><br></div></blockquote><div><br></div></div><div>I bracket code that make sense for analysis, and not necessarily at function boundaries. This is not standard so I will hide them with a private #define.</div></div>
</blockquote><div><br></div><div>It is hard for me to believe that these names are more meaningful to you than PC_GAMGCreateProl and similar. ;-)</div><div><br></div><div>enum tag {SET1,SET2,GRAPH,GRAPH_MAT,GRAPH_FILTER,GRAPH_SQR,SET4,SET5,SET6,FIND_V,SET7,SET8,SET9,SET10,SET11,SET12,SET13,SET14,SET15,SET16,NUM_SET};<br>
</div><div><br></div><div>Making the events truly match your function names is low priority in my opinion, but it would be nice eventually because it helps people navigate between a log_summary and the corresponding code.</div>
<div><br></div><div><br></div></div>
</blockquote><br></div>Yes, I know its a mess but I have my priorities ... these are very fluid things anyway so I'm not worried about being super clear. When things settle down a bit I'll firm them up.</body></html>