I wrote this before the thread moved to petsc-dev, so there is some overlap with the below.<div><div>A given problem with the same "topology" -- a mesh and a total index layout -- might define several useful splits -- collections of fields. Each field might have further useful splits. I have useful examples from my interaction with Moose/libMesh, although these are rather general. A field is now represented by an IS. We could try to put netsted split definitions into ISs (e.g., ISNest), but I think it's much more natural to keep all nestedness inside DMs -- we already have examples of this in the coarsening, refinement for MG and a pretty well understood interaction of this sort of DM hierarchy. with a hierarchy of PCs.</div>
<div><br></div><div>Thus, I think it would be useful for a DM to return a split as a list of DMs, which can be further split, if necessary:</div><div> DMGetFieldDMs(DM dm, PetscInt *fieldcount, DM **fielddms);</div>
<div>The field names can simply be the corresponding DM names, etc. The fielddms can be lightweight, sharing the underlying</div><div>topology. That's up to the implementation to arrange, though. This addresses nested splits.</div>
<div><br></div><div>We could use the same mehanism to implement alternative splits on the same topology -- these are different DMs sharing the topology internally. Instead of pushing and popping splits, they can be retrieved by name as </div>
<div> DMGetSplitDM(DM dm, const char *splitname, DM *splitdm);</div><div>Then calling DMGetFieldDMs on the splitdm retrieves the corresponding fields.</div><div>Again, splitdm and dm can share common data structures, as arranged by the particular DM implementation.</div>
<div>The advantage of this approach over push/pop is that we can simultaneously use different splits of the same topology.</div><div><br></div><div>It is rather easy to apply the same scheme and have DMs serve up (overlapping) domain decompositions useful for (G)ASM.</div>
<div>I'm now implementing both of these schemes (fieldsplit and subdomains) on top of libMesh, but the code resides in the libMesh source tree to avoid a circular dependence: as designed right now libMesh depends on PETSc. The API has to live in DM, though.</div>
<div><br></div><br><div class="gmail_quote">On Sat, Feb 25, 2012 at 12:36 PM, Barry Smith <span dir="ltr"><<a href="mailto:bsmith@mcs.anl.gov">bsmith@mcs.anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Feb 25, 2012, at 12:13 PM, Jed Brown wrote:<br>
<br>
> [migrating from petsc-maint]<br>
<div class="im">><br>
> > What interface are we going to use for splitting out a DM for a vector<br>
> > field in a larger system? How do we get the bs=2 velocity DM out of the<br>
> > lid-driven cavity's bs=4 velocity, vorticity, and temperature DM?<br>
> ><br>
><br>
> again this is irrelevent here because the same issue is true for the ISs.<br>
><br>
> But<br>
><br>
> I explained this in my previous email: DMPushSubDMType(DM,"name of a type of splitting like u,v,p or velocity,p"); DMPopSubDMType(); it is not perfect but a start. See that email for more details.<br>
><br>
> // Conservative gas dynamics with fields ordered as [rho, rho*u, rho*v, rho*w, E]<br>
> DMGetFieldSplitting(dm,"conservative-vector",&fscons); // creates if it doesn't exist<br>
> DMFieldSplittingAddField(dm,fscons,"rho",{0});<br>
> DMFieldSplittingAddField(dm,fscons,"momentum",{1,2,3});<br>
> DMFieldSplittingAddField(dm,fscons,"Energy",{4});<br>
><br>
> DMGetFieldSplitting(dm,"primitive-vector",&fsprim);<br>
> DMFieldSplittingSetPF(dm,fsprim,UserEquationOfStatePF,UserEquationOfStateInversePF);<br>
> DMFieldSplittingAddField(dm,fsprim,"velocity",{0,1,2});<br>
> DMFieldSplittingAddField(dm,fsprim,"pressure",{3});<br>
> DMFieldSplittingAddField(dm,fsprim,"Temperature",{4});<br>
><br>
> If a transform is not specified, the indices would address the original state variables.<br></div></blockquote><div><br></div><div>This API is for constructing splits, rather than pulling them out.</div><div>The two APIs do not conflict, but certain implementations might already have "naturally defined" splits</div>
<div>(e.g., in libMesh by variable name).</div><div> </div><div>Dmitry.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
</div> Jed, It also makes it impossible to handle bizare things where for one spitting you want a subset of one thing actually in another thing. So why not use IS to define the names, this gives complete flexibility. Also this above is not adding fields: you are just giving names to subsets of fields indicated by the original numbering of fields. Which is fine, but has confusing names (you are not AddField just naming it). My suggestion is just a more or less a concise way of doing what you are doing without the need for YET ANOTHER CLASS (fcons).<br>
<div class="im"><br>
><br>
> Then PCFieldSplit and eventual nonlinear and time-stepping splitting methods would call<br>
><br>
> DMGetFieldSplitting(dm,&nsplits,&splits);<br>
> // choose split number to use<br>
> split = splits[splitidx];<br>
> DMFieldSplittingGetName(dm,split,&splitname);<br>
> DMFieldSplittingGetFields(dm,split,&pf,&pfinv,&nfields,&isfields,&dmfields);<br>
<br>
</div>I do not like this approach based on requesting by name, just push your name and then pop it. This way something "above" in the call stack can push to the right one then something further down can use it without having to know its name (sort of like your "default" split) but the push allows changing the default. You kind of assume that the guts is suppose to know what name to use? // choose split number to use how is some PC deep inside suppose to know this?<br>
<br>
I realize my proposal was not complete on detail. I'm suggesting changes to your detail.<br>
<span class="HOEnZb"><font color="#888888"><br>
Barry<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> If pf is not NULL, apply PF to the state variables, then isfields[i] denotes what to extract in order to live in dmfields[i], pfinv is needed to put a contribution back into the coupled dm.<br>
<br></div></div></blockquote><div><br></div><div> </div></div><br></div>