[petsc-dev] please don't put obviously broken code into next

Barry Smith bsmith at mcs.anl.gov
Wed May 31 19:19:49 CDT 2017


  Or at least check the results mailed back from travis for problems.


/Users/travis/build/petsc/petsc/src/dm/dt/interface/dtds.c:169:87: error: cannot pass object of non-POD type 'const PetscScalar' (aka 'const complex<double>') through variadic function; call will abort at runtime [-Wnon-pod-varargs]
    for (f = 0; f < numConstants; ++f) {ierr = PetscViewerASCIIPrintf(viewer, "%g\n", constants[f]);CHKERRQ(ierr);}


Even if constants[f] was a real it would still need a (double) cast in front of it.

This kind of crap slows down everyone.





More information about the petsc-dev mailing list