[petsc-dev] Adding support memkind allocators in PETSc

Barry Smith bsmith at mcs.anl.gov
Wed Jun 3 22:01:48 CDT 2015


> On Jun 3, 2015, at 9:58 PM, Jeff Hammond <jeff.science at gmail.com> wrote:
> 
> http://git.mpich.org/mpich.git/blob/HEAD:/src/mpi/init/init.c
> https://github.com/open-mpi/ompi/blob/master/ompi/mpi/c/init.c

  As I said, super insane :-)

  Barry

  I'm just having fun here; I do believe that 2 is the ultimate correct indentation but I can always run a preprocessor to fix their code before I use it :-)

> 
> Jeff
> 
> On Wed, Jun 3, 2015 at 9:43 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
>> 
>>  Jeff,
>> 
>>   Ahh, from this page, it is definitively clear that the Intel people have their heads totally up their asses
>> 
>> formatted source code with astyle --style=linux --indent=spaces=4 -y -S
>> 
>> when everyone knows that any indent that is not 2 characters is totally insane :-)
>> 
>>  Barry
>> 
>> 
>>> On Jun 3, 2015, at 9:37 PM, Jeff Hammond <jeff.science at gmail.com> wrote:
>>> 
>>>>> but it screws up memkind's partitioning of the heap (it won't be aware
>>>>> that the pages have been moved).
>>>> 
>>>> Then memkind is stupid or the kernel isn't exposing the correct
>>>> information to memkind.  Tell them to not be lazy and do it right.
>>> 
>>> The beauty of git/github is one can make branches to try out anything
>>> they want even if Jed thinks that he knows better than Intel how to
>>> write system software for Intel's hardware.
>>> 
>>> This link is equivalent to pushing the "Fork" button on Github's
>>> memkind page: https://github.com/memkind/memkind#fork-destination-box.
>>> I'm sure that the memkind developers would be willing to review your
>>> pull request once you've implemented memkind_move_pages().
>>> 
>>> Jeff
>>> 
>>> --
>>> Jeff Hammond
>>> jeff.science at gmail.com
>>> http://jeffhammond.github.io/
>> 
> 
> 
> 
> -- 
> Jeff Hammond
> jeff.science at gmail.com
> http://jeffhammond.github.io/




More information about the petsc-dev mailing list