[petsc-dev] SNESConvergedDefault() side effect?

[Jed Brown]

Dmitry Karpeyev <karpeev at mcs.anl.gov> writes:
> Also, this is a minor point, but isn't SNESKSPEW_PreSolve() misnamed?
> It operates on a KSP and takes a SNES context, so shouldn't it be
> KSPPreSolve_SNESEW() or some such?

Yes, it is passed to KSPSetPreSolve, so it should be named something
like KSPPreSolve_SNESEW.

> Should we also fix SNESSkipConverged() --> SNESConvergedSkip() at the same
> time?

Yes, that was the intent of my last comment.  It was missed when
SNESDefaultConverged was renamed to SNESConvergedDefault.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130724/db57a888/attachment.sig>