[petsc-dev] PETSC_DESIRE_COMPLEX nonsense

[Barry Smith]

   Ok, hypre sucks and C99 complex sucks.

   Barry


On Nov 2, 2012, at 11:07 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> The reason is that Hypre headers are broken if complex.h is included, therefore we need some hack to prevent it from being visible in that setting. (The user might have the same problem.)
> 
> Oh, are you saying that we should still guard inclusion and definition of PetscComplex to compilation units defining PETSC_DESIRE_COMPLEX, but define PETSC_HAVE_COMPLEX regardless? That's fine with me.
> 
> With all these complexes running around, what are we going to do about Matt's psychological condition?
> 
> 
> On Fri, Nov 2, 2012 at 10:56 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> 
>    Seems unnecessarily convoluted.  Why not just have PETSC_HAVE_COMPLEX defined if either PETSC_HAVE_CXX_COMPLEX  or PETSC_HAVE_C99_COMPLEX  is defined in petscconf.h
> 
>    Why restrict knowledge of complex to certain files with #define PETSC_DESIRE_COMPLEX at the top?
> 
>     Barry
> 
>