[petsc-dev] API changes in MatIS

[Jed Brown]

All public API changes have to be documented at
src/docs/website/documentation/changes/dev.html.

http://petsc.cs.iit.edu/petsc/petsc-dev/rev/a942f19a37c9

Some questions and comments on this patch:

1. Why don't you use the API (e.g. PetscLayoutSetBlockSize()) when setting
the block size?

2. What was wrong with the default MatGetVecs()?

3. Options prefixes should inherit the prefix from the parent and should
end with "_" so that they aren't squashed together with the suboptions.

4. MatCreateIS() leaks the new Vec "global".

5. Why is the matrix being forced to be square?

6. Why is the size of the rmap/cmap being changed to be possibly different
from m,n,M,N passed in? By not using the PetscLayout API, it looks like we
can end up with a corrupt PetscLayout this way.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120507/2f08700d/attachment.html>