Yes, that patch works fine. It might not be the final solution, but it does make the assert pass, and I can run my app. I think it is a very good idea.<div><br></div><div>What about this part of the comment:</div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;">
"Also, we don't support compilers which add random padding to the start of the structure."</blockquote><div>Essentially, the compiler added 4 bytes to the <i>end</i> of a different structure that you are using in your new structure. Might that be a concern?</div>
<div><br></div><div><br><div class="gmail_quote">On Tue, Jun 9, 2009 at 4:06 PM, Darius Buntinas <span dir="ltr"><<a href="mailto:buntinas@mcs.anl.gov">buntinas@mcs.anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Joe, can you check if this patch works for you?<br>
<br>
Thanks,<br>
-d<br>
<br>
Index: src/mpid/ch3/channels/nemesis/nemesis/src/mpid_nem_init.c<br>
===================================================================<br>
--- src/mpid/ch3/channels/nemesis/nemesis/src/mpid_nem_init.c (revision<br>
4676)<br>
+++ src/mpid/ch3/channels/nemesis/nemesis/src/mpid_nem_init.c (working copy)<br>
@@ -86,7 +86,7 @@<br>
<div class="im"> * should only contain a pointer. Also, we don't support compilers<br>
* which add random padding to the start of the structure. The<br>
* below assert should blow up if any of these happens. */<br>
- MPIU_Assert(sizeof(MPID_nem_cell_rel_ptr_t) == SIZEOF_VOID_P);<br>
</div>+ MPIU_Assert(sizeof(MPID_nem_cell_rel_ptr_t) == sizeof(OPA_ptr_t));<br>
<br>
/* Make sure the cell structure looks like it should */<br>
MPIU_Assert(MPID_NEM_CELL_PAYLOAD_LEN + MPID_NEM_CELL_HEAD_LEN ==<br>
sizeof(MPID_nem_cell_t));<br>
<div><div></div><div class="h5"><br>
<br>
<br>
<br>
On 06/09/2009 03:58 PM, Darius Buntinas wrote:<br>
> I believe it should be exactly the size of an OPA_ptr_t. I'm checking<br>
> this right now.<br>
><br>
> -d<br>
><br>
>> I think the bigger question is whether or not the assertion is<br>
>> sensible. I don't know why the cell rel pointer structure needs to be<br>
>> exactly the same size as a pointer as long as it contains a pointer<br>
>> value...<br>
</div></div><div><div></div><div class="h5">_______________________________________________<br>
opa-core mailing list<br>
<a href="mailto:opa-core@lists.mcs.anl.gov">opa-core@lists.mcs.anl.gov</a><br>
<a href="https://lists.mcs.anl.gov/mailman/listinfo/opa-core" target="_blank">https://lists.mcs.anl.gov/mailman/listinfo/opa-core</a><br>
</div></div></blockquote></div><br></div>