<div dir="ltr">Go ahead and make the changes to fix the tests Iulian. <div><br></div><div>If the test mesh files are not part of the repo, they should be. Paul, can you commit those files to master directly (this should've been part of the merge).</div>
<div><br></div><div>Vijay</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 27, 2014 at 9:57 AM, Grindeanu, Iulian R. <span dir="ltr"><<a href="mailto:iulian@mcs.anl.gov" target="_blank">iulian@mcs.anl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-size:10pt;font-family:Tahoma"> the mesh files are not part of distribution if they are not in EXTRA_DIST variable in Makefile.am in the mesh folder
<br>
these tests are using (incorrectly) MESHDIR variable<br>
for example:<br>
test/dagmc/dagmc_simple_test.cpp<br>
#ifdef MESHDIR<br>
static const char input_file[] = STRINGIFY(MESHDIR) "/dagmc/test_geom.h5m";<br>
#else<br>
static const char input_file[] = STRINGIFY(MESHDIR) "/dagmc/test_geom.h5m";<br>
#endif<br>
<br>
I just noticed another problem with iGeom test file, it is missing too a reference.<br>
<br>
iGeom and dagmc need to be added in SUBDIRS variable in MeshFiles/unittest/Makefile.am<br>
And Makefile.am files need to be added to MeshFiles/unittest/iGeom and dagmc folders, with EXTRA_DIST variables in them<br>
<div style="font-size:16px;font-family:Times New Roman">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> Vijay S. Mahadevan [<a href="mailto:vijay.m@gmail.com" target="_blank">vijay.m@gmail.com</a>]<br>
<b>Sent:</b> Thursday, March 27, 2014 9:41 AM<br>
<b>To:</b> Grindeanu, Iulian R.; Paul Wilson<br>
<b>Cc:</b> <a href="mailto:moab-dev@mcs.anl.gov" target="_blank">moab-dev@mcs.anl.gov</a><br>
<b>Subject:</b> Re: [MOAB-dev] buildbot failure in moab-netcdf: failed test<br>
</font><br>
</div><div><div class="h5">
<div></div>
<div>
<div dir="ltr">Iuian, Does this need any changes in the test files to use MESHDIR variable like in the others to abstract out the actual location of the mesh files ?
<div><br>
</div>
<div>Paul, please verify if the latest merge passed all tests on your end for an out-of-source build.
<div><br>
</div>
<div>Vijay</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Mar 27, 2014 at 9:00 AM, Grindeanu, Iulian R. <span dir="ltr">
<<a href="mailto:iulian@mcs.anl.gov" target="_blank">iulian@mcs.anl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-size:10pt;font-family:Tahoma">this particular error was caused by reliance on building with hdf5<br>
these tests, that load an hdf5 file, need to be launched only when building with hdf5<br>
Some of the configurations in buildbot test moab without hdf5<br>
(moab-netcdf, moab-bare) etc<br>
example is this<br>
if HDF5_FILE<br>
TESTS += mbfacet_test \<br>
gttool_test \<br>
cropvol_test \<br>
mergemesh_test \<br>
mbground_test \<br>
lloyd_smoother_test<br>
endif<br>
in test/Makefile.am<br>
<br>
distcheck fails because it is an out of source build, and the mesh files that are loaded need to be included in the distribution (EXTRA_DIST variable in Makefile.am in mesh files directory)<br>
<div style="font-size:16px;font-family:Times New Roman">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> <a href="mailto:moab-dev-bounces@mcs.anl.gov" target="_blank">
moab-dev-bounces@mcs.anl.gov</a> [<a href="mailto:moab-dev-bounces@mcs.anl.gov" target="_blank">moab-dev-bounces@mcs.anl.gov</a>] on behalf of
<a href="mailto:moab-dev@mcs.anl.gov" target="_blank">moab-dev@mcs.anl.gov</a> [<a href="mailto:moab-dev@mcs.anl.gov" target="_blank">moab-dev@mcs.anl.gov</a>]<br>
<b>Sent:</b> Thursday, March 27, 2014 1:08 AM<br>
<b>To:</b> <a href="mailto:moab-dev@mcs.anl.gov" target="_blank">moab-dev@mcs.anl.gov</a><br>
<b>Subject:</b> [MOAB-dev] buildbot failure in moab-netcdf: failed test<br>
</font><br>
</div>
<div></div>
<div>
<div>
<div>
<h1><a href="http://gnep.mcs.anl.gov:8010/" target="_blank">Fathom</a>: <a href="http://gnep.mcs.anl.gov:8010/builders/moab-netcdf" target="_blank">
moab-netcdf</a> build <a href="http://gnep.mcs.anl.gov:8010/builders/moab-netcdf/builds/309" target="_blank">
#309</a></h1>
<table>
<tbody>
<tr>
<td><b>Results:</b></td>
<td>failed test</td>
</tr>
<tr>
<td><b>Buildslave:</b></td>
<td>gnep</td>
</tr>
<tr>
<td><b>Revision:</b></td>
<td>None</td>
</tr>
<tr>
<td><b>Reason:</b></td>
<td>The Nightly scheduler named 'moab-netcdf' triggered this build</td>
</tr>
</tbody>
</table>
<h2>Log Excerpt</h2>
</div>
</div>
<pre><div><div>dagmc_pointinvol_test.cpp:39:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:39: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:51:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:51: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:59:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:59: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:81:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:81: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:103:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:103: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:125:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:125: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:147:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:147: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:169:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:169: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:191:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:191: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:221:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:221: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:251:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:251: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:281:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:281: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:311:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:311: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:341:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:341: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:371:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:371: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp:401:25: warning: integer constant is so large that it is unsigned
dagmc_pointinvol_test.cpp:401: warning: this decimal constant is unsigned only in ISO C90
dagmc_pointinvol_test.cpp: In function ‘void dagmc_point_in()’:
dagmc_pointinvol_test.cpp:52: warning: unused variable ‘rval’
dagmc_pointinvol_test.cpp: In function ‘void dagmc_setup_test()’:
dagmc_pointinvol_test.cpp:38: warning: ‘vol’ may be used uninitialized in this function
mv -f .deps/dagmc_pointinvol_test-dagmc_pointinvol_test.Tpo .deps/dagmc_pointinvol_test-dagmc_pointinvol_test.Po
/bin/sh ../../libtool --tag=CXX --mode=link g++ -Wall -pipe -pedantic -Wno-long-long -Wextra -Wcast-align -Wpointer-arith -Wformat -Wformat-security -Wshadow -Wunused-parameter -O2 -DNDEBUG -Wall -pipe -pedantic -Wno-long-long -Wextra -Wcast-align -Wpointer-arith -Wformat -Wformat-security -Wshadow -Wunused-parameter -O2 -DNDEBUG -L/home/fathom/3rdparty/netcdf/netcdf-4.0.1/serial/gcc/lib -lnetcdf -L/home/fathom/3rdparty/hdf5/hdf5-1.8.3/serial/gcc -lhdf5_hl -lhdf5 -L/home/fathom/3rdparty/zlib/zlib-1.2.4/gcc -lz -o dagmc_pointinvol_test dagmc_pointinvol_test-dagmc_pointinvol_test.o ../../src/libMOAB.la ../../tools/dagmc/DagMC.lo -lm
libtool: link: g++ -Wall -pipe -pedantic -Wno-long-long -Wextra -Wcast-align -Wpointer-arith -Wformat -Wformat-security -Wshadow -Wunused-parameter -O2 -DNDEBUG -Wall -pipe -pedantic -Wno-long-long -Wextra -Wcast-align -Wpointer-arith -Wformat -Wformat-security -Wshadow -Wunused-parameter -O2 -DNDEBUG -o dagmc_pointinvol_test dagmc_pointinvol_test-dagmc_pointinvol_test.o ../../tools/dagmc/DagMC.o -L/home/fathom/3rdparty/netcdf/netcdf-4.0.1/serial/gcc/lib -L/home/fathom/3rdparty/hdf5/hdf5-1.8.3/serial/gcc/lib -L/home/fathom/3rdparty/zlib/zlib-1.2.4/gcc/lib -L/home/fathom/3rdparty/szip/szip-2.1/gcc/lib -L/home/fathom/3rdparty/hdf5/hdf5-1.8.3/serial/gcc -L/usr/lib/mpich/lib/ -L/home/fathom/3rdparty/zlib/zlib-1.2.4/gcc ../../src/.libs/libMOAB.a /home/fathom/3rdparty/netcdf/netcdf-4.0.1/serial/gcc/lib/libnetcdf.so /usr/lib/libhdf5_hl.so /usr/lib/libhdf5.so -lpthread -lz -lm -Wl,-rpath -Wl,/home/fathom/3rdparty/netcdf/netcdf-4.0.1/serial/gcc/lib -Wl,-rpath -Wl,/home/fathom/3rdpart
y/netcdf/netcdf-4.0.1/serial/gcc/lib
...make check-TESTS
make[4]: Entering directory `/disks/itaps-buildslave/moab-netcdf/build/test/dagmc'
make[5]: Entering directory `/disks/itaps-buildslave/moab-</div></div>netcdf/build/test/dagmc'
?[0;31mFAIL?[m: dagmc_simple_test
?[0;31mFAIL?[m: dagmc_rayfire_test
?[0;31mFAIL?[m: dagmc_pointinvol_test
?[0;31m=============================
3 of 3 tests failed
See test/dagmc/test-suite.log
=============================
?[mmake[5]: *** [test-suite.log] Error 1
</pre>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>