<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div>You are right, this commit didn't break anything. </div><div>I didn't test this code before, my guess is some similar fix is need for resolving shared sets.</div><div> </div><div><font style="font-family: arial, helvetica, sans-serif; " size="2">Rajeev</font><br><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><div style="font-size: 10pt; font-family: arial, helvetica, sans-serif; "><div style="font-size: 12pt; font-family: 'times new roman', 'new york', times, serif; "><font size="2" face="Arial"><hr size="1"><b><span style="font-weight:bold;">From:</span></b> Hong-Jun Kim <hongjun@mcs.anl.gov><br><b><span style="font-weight: bold;">To:</span></b> Rajeev Jain <jain@mcs.anl.gov><br><b><span style="font-weight: bold;">Cc:</span></b>
moab-dev@mcs.anl.gov<br><b><span style="font-weight: bold;">Sent:</span></b> Monday, October 3, 2011 5:28 PM<br><b><span style="font-weight: bold;">Subject:</span></b> Re: [MOAB-dev] r5182 - in MOAB/trunk/src/parallel: . moab<br></font><br>
Actually, this commit seems not to do anything related to resolving shared sets.<br>Was your code working with the previous version of MOAB?<br><br>Hong-Jun<br><br>----- Original Message -----<br>> From: "Rajeev Jain" <<a ymailto="mailto:jain@mcs.anl.gov" href="mailto:jain@mcs.anl.gov">jain@mcs.anl.gov</a>><br>> To: <a ymailto="mailto:moab-dev@mcs.anl.gov" href="mailto:moab-dev@mcs.anl.gov">moab-dev@mcs.anl.gov</a><br>> Sent: Monday, October 3, 2011 5:11:25 PM<br>> Subject: Re: [MOAB-dev] r5182 - in MOAB/trunk/src/parallel: . moab<br>> Hi Hong-Jun,<br>> Is there some change needed for "unpack_set" function (below)?<br>> <br>> <br>> ErrorCode WriteHDF5Parallel::unpack_set( EntityHandle set,<br>> const unsigned long* buffer,<br>> size_t buffer_size )<br>> {<br>> // use local variables for readability<br>> assert(buffer_size >= 4);<br>> assert(buffer[1]+buffer[2]+buffer[3] <= buffer_size);<br>>
....<br>> <br>> <br>> <br>> <br>> CoreGen resolves MATERIAL_SET's using the "resolve_shared_sets"<br>> function before calling parallel save, the following error occurs and<br>> the process is terminated:<br>> <br>> "<br>> 3 H5M *********** Debug Barrier 7 (@412)***********<br>> 0 H5M (1.60 s) creating meshset table<br>> ...<br>> ...<br>> 0 H5M (1.61 s) COMMUNICATING SHARED SET DATA (0 owned & 0 remote)<br>> 0 H5M Using buffer size of 128 for an expected message count of 0<br>> [2] Assert(buffer[1]+buffer[2]+buffer[3] <= buffer_size) failed at<br>> WriteHDF5Parallel.cpp:1727<br>> Terminated (signal 15)<br>> "<br>> <br>> Rajeev<br>> <br>> <br>> <br>> <br>> <br>> <br>> From: "<a ymailto="mailto:hongjun@mcs.anl.gov" href="mailto:hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a>" <<a ymailto="mailto:hongjun@mcs.anl.gov"
href="mailto:hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a>><br>> To: <a ymailto="mailto:moab-dev@mcs.anl.gov" href="mailto:moab-dev@mcs.anl.gov">moab-dev@mcs.anl.gov</a><br>> Sent: Friday, September 30, 2011 6:26 PM<br>> Subject: [MOAB-dev] r5182 - in MOAB/trunk/src/parallel: . moab<br>> <br>> Author: hongjun<br>> Date: 2011-09-30 18:26:09 -0500 (Fri, 30 Sep 2011)<br>> New Revision: 5182<br>> <br>> Modified:<br>> MOAB/trunk/src/parallel/ParallelComm.cpp<br>> MOAB/trunk/src/parallel/moab/ParallelComm.hpp<br>> Log:<br>> o "created_iface" flag is added in "unpack_entities" function<br>> o it is used in "exchange_owned_mesh" and it is for recognizing with<br>> ghost mesh element and non-ghost newly created mesh element<br>> o it prevents to assign "PSTATUS_NOT_OWNED" and "PSTATUS_GHOST" for<br>> non-ghost newly created mesh elements<br>> o passes make check<br>> <br>> <br>> Modified:
MOAB/trunk/src/parallel/ParallelComm.cpp<br>> ===================================================================<br>> --- MOAB/trunk/src/parallel/ParallelComm.cpp 2011-09-29 21:08:52 UTC<br>> (rev 5181)<br>> +++ MOAB/trunk/src/parallel/ParallelComm.cpp 2011-09-30 23:26:09 UTC<br>> (rev 5182)<br>> @@ -960,12 +960,13 @@<br>> std::vector<EntityHandle> &L2hloc,<br>> std::vector<EntityHandle> &L2hrem,<br>> std::vector<unsigned int> &L2p,<br>> - std::vector<EntityHandle> &new_ents)<br>> + std::vector<EntityHandle> &new_ents,<br>> + const bool created_iface)<br>> {<br>> unsigned char *tmp_buff = buff_ptr;<br>> ErrorCode result;<br>> result = unpack_entities(buff_ptr, store_remote_handles,<br>> - ind, false, L1hloc, L1hrem, L1p, L2hloc, L2hrem, L2p, new_ents);<br>> + ind, false, L1hloc, L1hrem, L1p, L2hloc, L2hrem, L2p, new_ents,<br>>
created_iface);<br>> RRA("Unpacking entities failed.");<br>> if (myDebug->get_verbosity() == 3) {<br>> myDebug->tprintf(4, "unpack_entities buffer space: %ld bytes.\n",<br>> (long int)(buff_ptr-tmp_buff));<br>> @@ -1585,7 +1586,8 @@<br>> std::vector<EntityHandle> &L2hloc,<br>> std::vector<EntityHandle> &L2hrem,<br>> std::vector<unsigned int> &L2p,<br>> - std::vector<EntityHandle> &new_ents)<br>> + std::vector<EntityHandle> &new_ents,<br>> + const bool created_iface)<br>> {<br>> // general algorithm:<br>> // - unpack # entities<br>> @@ -1769,7 +1771,8 @@<br>> // update sharing data and pstatus, adjusting order if iface<br>> result = update_remote_data(new_h, &ps[0], &hs[0], num_ps,<br>> (is_iface ? PSTATUS_INTERFACE :<br>> - (created_here ? (PSTATUS_GHOST | PSTATUS_NOT_OWNED) : 0)));<br>> + (created_here ? (created_iface ? 0 :
PSTATUS_GHOST<br>> + | PSTATUS_NOT_OWNED) : 0)));<br>> RRA("");<br>> <br>> // need to send this new handle to all sharing procs<br>> @@ -5918,7 +5921,8 @@<br>> remoteOwnedBuffs[ind/2]->reset_ptr(sizeof(int));<br>> result = unpack_buffer(remoteOwnedBuffs[ind/2]->buff_ptr,<br>> store_remote_handles, buffProcs[ind/2], ind/2,<br>> - L1hloc, L1hrem, L1p, L2hloc, L2hrem, L2p, new_ents);<br>> + L1hloc, L1hrem, L1p, L2hloc, L2hrem, L2p,<br>> + new_ents, true);<br>> if (MB_SUCCESS != result) {<br>> std::cout << "Failed to unpack entities. Buffer contents:" <<<br>> std::endl;<br>> print_buffer(remoteOwnedBuffs[ind/2]->mem_ptr, MB_MESG_ENTS_SIZE,<br>> buffProcs[ind/2], false);<br><br><br></div></div></blockquote></div></div></body></html>