<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Dec 16, 2013 at 12:46 PM, Iulian Grindeanu <span dir="ltr"><<a href="mailto:iulian@mcs.anl.gov" target="_blank">iulian@mcs.anl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div style="font-size:12pt;font-family:'times new roman','new york',times,serif">
<br><br><hr><div class="im"><blockquote style="padding-left:5px;font-size:12pt;font-style:normal;margin-left:5px;font-family:Helvetica,Arial,sans-serif;text-decoration:none;font-weight:normal;border-left-width:2px;border-left-style:solid;border-left-color:rgb(16,16,255)">
<div dir="ltr">Hi Iulian, <div><br></div><div>To differentiate in the test iGeom will have to have a version number associated with it that is accessible from Python (probably via another part of PyTAPS). Then you can compare the version number and execute the appropriate part of the test. </div>
</div></blockquote></div>yes, this is something I don't know how to do. Or what is the standard/preferred way to do it in python. <br></div></div></blockquote><div><br></div><div>Often times people just have a "__version__" str in their package's base __init__.py. That would be the appropriate thing to do for PyTAPS. For igeom, etc, it might be most appropriate to just have a namedtuple, whose instance is called something like 'version_info' like is done for Python itself in the sys module [1]</div>
<div><br></div><div>1. <a href="http://docs.python.org/2/library/sys.html#sys.version_info">http://docs.python.org/2/library/sys.html#sys.version_info</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div style="font-size:12pt;font-family:'times new roman','new york',times,serif"><div class="im"><blockquote style="padding-left:5px;font-size:12pt;font-style:normal;margin-left:5px;font-family:Helvetica,Arial,sans-serif;text-decoration:none;font-weight:normal;border-left-width:2px;border-left-style:solid;border-left-color:rgb(16,16,255)">
<div dir="ltr"><div></div>
<div><br></div><div>Arguably a better solution would be for the PyTAPS wrapper function to keep the same API it has now, test what version of igeom it has, and perform the appropriate call. This is a much better solution because then downstream code, tests included, won't need to change. </div>
</div></blockquote></div>this is a good idea, and I can do it without exporting anything else. It is just that the new argument (point) will always be [0,0,0],<br>so we cannot test anything else. If we always pass 0, why bother with modifying iGeom?</div>
</div></blockquote><div><br></div><div>Yup, sounds good to me. It might be nice if this was a keyword argument so the user could modify it if they <i>really</i> wanted to, but that is not necessary.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div style="font-size:12pt;font-family:'times new roman','new york',times,serif"><div class="im"><br><blockquote style="padding-left:5px;font-size:12pt;font-style:normal;margin-left:5px;font-family:Helvetica,Arial,sans-serif;text-decoration:none;font-weight:normal;border-left-width:2px;border-left-style:solid;border-left-color:rgb(16,16,255)">
<div dir="ltr"><div></div>
<div><br></div><div>For further arguments sake, it is probably not the right thing to do for the function signatures to change on micro version numbers. This is really bad for stability. I don't know what the specific use case is here,though, so maybe it is justified. </div>
<div><br></div></div></blockquote></div>yes, this is a good point. changing interface is never a good thing; and micro versions should never change function signatures. <br>It should be at least version 1.5.0 then :) <br>
</div></div></blockquote><div><br></div><div>At least :).</div><div><br></div><div>Be Well</div><div>Anthony</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div style="font-size:12pt;font-family:'times new roman','new york',times,serif"><br>Thanks,<br>Iulian<br><br><blockquote style="padding-left:5px;font-size:12pt;font-style:normal;margin-left:5px;font-family:Helvetica,Arial,sans-serif;text-decoration:none;font-weight:normal;border-left-width:2px;border-left-style:solid;border-left-color:rgb(16,16,255)">
<div dir="ltr"><div></div><div>Be Well</div><div>Anthony</div></div><br></blockquote></div></div></blockquote></div><br></div></div>