<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;">Hi, Hong-Jun,<br><br>Please see r5102 for fix of your model. Thanks for fixing the nightly build issues.<br><br>Jane<br><br>--- On <b>Fri, 8/12/11, Hong-Jun Kim <i><hongjun@mcs.anl.gov></i></b> wrote:<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><br>From: Hong-Jun Kim <hongjun@mcs.anl.gov><br>Subject: Re: [cgma-dev] r5088 - cgm/trunk/geom/OCC<br>To: "Jane Hu" <janejhu@gmail.com><br>Cc: cgma-dev@mcs.anl.gov, "Jiangtao Hu" <jiangtao_ma@yahoo.com><br>Date: Friday, August 12, 2011, 5:53 PM<br><br><div class="plainMail">Hi, Jane<br><br>Could you please check the attached step file for "test_edge_orient" again?<br>4 similar shaped faces have problems in the test with OCC kernel.<br>Thanks.<br><br>-----------------------------<br>Hong-Jun Kim<br>Post-doc researcher<br>MCS, Argonne National
Laboratory<br>9700 S. Cass Ave. B240/R2147<br>Argonne, IL 60439<br>630-252-4791<br><a ymailto="mailto:hongjun@mcs.anl.gov" href="/mc/compose?to=hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a><br>-----------------------------<br><br>----- Original Message -----<br>From: "Jane Hu" <<a ymailto="mailto:janejhu@gmail.com" href="/mc/compose?to=janejhu@gmail.com">janejhu@gmail.com</a>><br>To: "Jiangtao Hu" <<a ymailto="mailto:jiangtao_ma@yahoo.com" href="/mc/compose?to=jiangtao_ma@yahoo.com">jiangtao_ma@yahoo.com</a>><br>Cc: "Hong-Jun Kim" <<a ymailto="mailto:hongjun@mcs.anl.gov" href="/mc/compose?to=hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a>>, <a ymailto="mailto:cgma-dev@mcs.anl.gov" href="/mc/compose?to=cgma-dev@mcs.anl.gov">cgma-dev@mcs.anl.gov</a><br>Sent: Friday, August 12, 2011 12:31:22 PM<br>Subject: Re: [cgma-dev] r5088 - cgm/trunk/geom/OCC<br><br>Hi, Hong-Jun <br><br>Please use r5098 to fix the problem seen in your model. Thanks.
<br><br>Jane <br><br><br>On Thu, Aug 11, 2011 at 10:58 PM, Jiangtao Hu < <a ymailto="mailto:jiangtao_ma@yahoo.com" href="/mc/compose?to=jiangtao_ma@yahoo.com">jiangtao_ma@yahoo.com</a> > wrote: <br><br><br><br><br>Sure, I'll look into this case tomorrow. Thanks for the model and your time finding it. <br><br>Jane <br><br>--- On Thu, 8/11/11, Hong-Jun Kim < <a ymailto="mailto:hongjun@mcs.anl.gov" href="/mc/compose?to=hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a> > wrote: <br><br><br><br><br>From: Hong-Jun Kim < <a ymailto="mailto:hongjun@mcs.anl.gov" href="/mc/compose?to=hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a> > <br><br>Subject: Re: [cgma-dev] r5088 - cgm/trunk/geom/OCC <br>To: <a ymailto="mailto:jiangtao_ma@yahoo.com" href="/mc/compose?to=jiangtao_ma@yahoo.com">jiangtao_ma@yahoo.com</a> <br>Cc: <a ymailto="mailto:cgma-dev@mcs.anl.gov" href="/mc/compose?to=cgma-dev@mcs.anl.gov">cgma-dev@mcs.anl.gov</a> <br>Date: Thursday, August 11,
2011, 5:12 PM <br><br><br><br><br><br>Hi, jane <br><br>I attached a step geometry file (with a picture) having problem in OCC kernel. <br>It passes the "test_edge_orient" in ACIS kernel but doesn't in OCC. <br>Could you please check this file? <br>Thanks. <br><br>Hong-Jun <br><br>----- Original Message ----- <br>From: "Hong-Jun Kim" < <a ymailto="mailto:hongjun@mcs.anl.gov" href="/mc/compose?to=hongjun@mcs.anl.gov">hongjun@mcs.anl.gov</a> > <br>To: <a ymailto="mailto:cgma-dev@mcs.anl.gov" href="/mc/compose?to=cgma-dev@mcs.anl.gov">cgma-dev@mcs.anl.gov</a> <br>Sent: Thursday, August 11, 2011 3:06:25 PM <br>Subject: Re: [cgma-dev] r5088 - cgm/trunk/geom/OCC <br><br>Thank you for this change. <br><br>I am testing it with complex geometries and it looks there are some improvement but it is not working for some cases. <br>I am still finding where the problem is coming from and let me inform you the result. <br>Thanks. <br><br>Hong-Jun <br><br>-----
Original Message ----- <br>> From: "jiangtao ma" < <a ymailto="mailto:jiangtao_ma@yahoo.com" href="/mc/compose?to=jiangtao_ma@yahoo.com">jiangtao_ma@yahoo.com</a> > <br>> To: <a ymailto="mailto:cgma-dev@mcs.anl.gov" href="/mc/compose?to=cgma-dev@mcs.anl.gov">cgma-dev@mcs.anl.gov</a> <br>> Sent: Thursday, August 11, 2011 9:21:55 AM <br>> Subject: [cgma-dev] r5088 - cgm/trunk/geom/OCC <br>> Author: janehu <br>> Date: 2011-08-11 09:21:55 -0500 (Thu, 11 Aug 2011) <br>> New Revision: 5088 <br>> <br>> Modified: <br>> cgm/trunk/geom/OCC/OCCCurve.cpp <br>> cgm/trunk/geom/OCC/OCCModifyEngine.cpp <br>> cgm/trunk/geom/OCC/OCCQueryEngine.cpp <br>> cgm/trunk/geom/OCC/OCCSurface.cpp <br>> Log: <br>> Added changes to make coedge and loop direction correct. For surfaces, <br>> opposite to acis where face is always forward direction respect to its <br>> volume, OCC surfaces and shell might be reversed direction
with <br>> respect to its solid. This may cause volume mesh fail, I am looking <br>> into it now, and might need to change some logic in the geom level of <br>> cgm. <br>> <br>> Modified: cgm/trunk/geom/OCC/OCCCurve.cpp <br>> =================================================================== <br>> --- cgm/trunk/geom/OCC/OCCCurve.cpp 2011-08-09 22:27:32 UTC (rev 5087) <br>> +++ cgm/trunk/geom/OCC/OCCCurve.cpp 2011-08-11 14:21:55 UTC (rev 5088) <br>> @@ -123,10 +123,10 @@ <br>> <br>> void OCCCurve::set_TopoDS_Edge(TopoDS_Edge edge) <br>> { <br>> - if(edge.IsEqual(*myTopoDSEdge)) <br>> + if(edge.IsSame(*myTopoDSEdge)) <br>> return; <br>> <br>> - if(!edge.IsSame(*myTopoDSEdge)) <br>> + else <br>> { <br>> DLIList<OCCPoint*> points ; <br>> this->get_points(points); <br>> @@ -737,8 +737,7 @@ <br>> double OCCCurve::start_param() <br>> { <br>> double start = 0.0, end = 0.0;
<br>> - <br>> - get_param_range( start, end ); <br>> + get_param_range( start, end ); <br>> return start; <br>> } <br>> <br>> @@ -781,29 +780,22 @@ <br>> { <br>> TopTools_IndexedMapOfShape M; <br>> TopExp::MapShapes(*myTopoDSEdge, TopAbs_VERTEX, M); <br>> - TopologyBridge *point1, *point2; <br>> - if (M.Extent()==1) { <br>> - point1 = OCCQueryEngine::instance()->occ_to_cgm(M(1)); <br>> - if (point1) <br>> - children.append_unique(point1); <br>> - } else if (M.Extent()==2) { <br>> - if ( fabs(BRep_Tool::Parameter(TopoDS::Vertex(M(1)), <br>> *myTopoDSEdge)-start_param()) > <br>> - fabs(BRep_Tool::Parameter(TopoDS::Vertex(M(2)), <br>> *myTopoDSEdge)-start_param()) ) { <br>> - point1 = OCCQueryEngine::instance()->occ_to_cgm(M(2)); <br>> - point2 = OCCQueryEngine::instance()->occ_to_cgm(M(1)); <br>> - } else { <br>> - point1 = OCCQueryEngine::instance()->occ_to_cgm(M(1));
<br>> - point2 = OCCQueryEngine::instance()->occ_to_cgm(M(2)); <br>> - } <br>> - if (point1 && point1 == point2) { <br>> - children.append_unique(point1); <br>> - } else { <br>> - if (point1) <br>> - children.append_unique(point1); <br>> - if (point2) <br><br></div></blockquote></td></tr></table>